primitives: Inline public functions #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit the `primitives` module and all submodules; add inline to all public methods that are small enough (excl. error impls).
|
concept ACK. I'm not sure what your exact criteria is and I'm not sure how to vet your choices, but nothing here seems particularly egregious. If we wanted a specific policy I think "one-liners and functions we've actually benchmarked to be faster with inlining" would be a good one. |
apoelstra
approved these changes
Aug 10, 2023
My critera was, after re-reading #1595 discussion, "kind of guess at what the assembler would be, given I know very little about compiler optimisations, and then aggressively inline. And if I was really unsure look at stdlib". So I skipped all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit the
primitivesmodule and all submodules; add inline to all public methods that are small enough (excl. error impls).