This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Add docs to the code create by sha256t_hash_newtype macro #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `sha256t_hash_newtype` currently no docs are generated, this causes lint errors for users who lint for such things. Add docs to the new type created by the `sha256t_hash_newtype` macro. (This is identical to how we do it in the duplicate macro of the same name in `rust-bitcoin`, which can be removed in favour of this one after this patch is applied.)
apoelstra
approved these changes
Apr 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
sha256t_hash_newtypecurrently no docs are generated,this causes lint errors for users who lint for such things.
Add docs to the new type created by the
sha256t_hash_newtypemacro.(This is identical to how we do it in the duplicate macro of the same
name in
rust-bitcoin, which can be removed in favour of this one afterthis patch is applied.)