Remove bitvec from default features #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Maybe bitvec-alloc could require alloc? (and bitvec-std require std) |
|
Should we first discuss in #1323 whether the bitvec parsers will remain part of the main crate? If so, this PR doesn't make sense. |
|
it makes sense in that I can push a 7.0.0-alpha with that fix right now, which would unlock the tarpaulin issue, and then we can see how to move bitvec in a separate crate for the real release (yes this is kinda cheating with semver) |
|
Done. |
|
thanks |
|
@djc https://crates.io/crates/nom/7.0.0-alpha1 (it also includes bitvec upgrades for now) |
nokome
added a commit
to stencila/stencila
that referenced
this pull request
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1287. That said, the approach suggested in #1323 would probably make more sense in the end.