Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'CARGO_WORKSPACE_DIR' if present, closes #33 #34

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

fasterthanlime
Copy link
Contributor

Will test that out on rust-lang/rust#99444 before taking it out of draft.

@fasterthanlime fasterthanlime marked this pull request as ready for review July 19, 2022 10:24
@fasterthanlime
Copy link
Contributor Author

This works well enough to resolve the problems we saw in rust-lang/rust#99444

using this PR, when adding an env section to rust-analyzer's .cargo/config.toml, all tests pass from within the rust repo

Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the crate version in the Cargo.toml? CI will auto-publish the version when we merge it then. And a small CHANGELOG.md entry would be nice as well :)

@fasterthanlime
Copy link
Contributor Author

Can you bump the crate version in the Cargo.toml? CI will auto-publish the version when we merge it then. And a small CHANGELOG.md entry would be nice as well :)

Done!

} else {
StrLitKind::Normal
};
return if has_bslash_or_newline { StrLitKind::Raw(1) } else { StrLitKind::Normal };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap, "format on save" strikes again

@Veykril Veykril merged commit 9d2aa5d into rust-analyzer:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants