srt-tokio: remove trust-dns-resolver dependency
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `trust-dns-resolver` a boatload of dependencies are removed from the project: * `data-encoding`, `enum-as-inner`, `heck`, `hostname`, `ipconfig`, `ipnet`, `linked-hash-map`, `lock_api`, `lru-cache`, `match_cfg`, `matches`, `parking_lot`, `resolv-conf`, `scopeguard`, `trust-dns-proto`, `trust-dns-resolver`, `widestring`, `winreg` If the user wants to use DNS-over-TLS, they can either lookup the name themself and supply a `SocketAddr` instead of a domain name, or they can set up their system resolver to use DNS-over-TLS. This PR effectly reverts <#202>, but fixes the bug in <#201> instead. The problem was actually that Tokio's `lookup_host()` resolves to a `SocketAddr` instead of an `IpAddr`, so its argument needs a domain name and a port, not only a domain name.
robertream
approved these changes
Jul 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 75.73% 75.66% -0.08%
==========================================
Files 88 85 -3
Lines 14339 14326 -13
==========================================
- Hits 10860 10840 -20
- Misses 3479 3486 +7
☔ View full report in Codecov by Sentry. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
trust-dns-resolvera boatload of dependencies are removed from the project:data-encoding,enum-as-inner,heck,hostname,ipconfig,ipnet,linked-hash-map,lock_api,lru-cache,match_cfg,matches,parking_lot,resolv-conf,scopeguard,trust-dns-proto,trust-dns-resolver,widestring,winregIf the user wants to use DNS-over-TLS, they can either lookup the name themself and supply a
SocketAddrinstead of a domain name, or they can set up their system resolver to use DNS-over-TLS.This PR effectly reverts #202, but fixes the bug in #201 instead. The problem was actually that Tokio's
lookup_host()resolves to aSocketAddrinstead of anIpAddr, so its argument needs a domain name and a port, not only a domain name.