Parent attributes namespaces in canonicalized document subsets #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equires that when canonicalizing a document subset that the namespace attributes from parent elements be included in the subset root element. This change adds support for this requirement.
|
cc @rowland66 We ran into this at work also. If we could get a review/merge that'd help us out. |
|
Good catch, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for XML canonicalization REC-xml-c14n-20010315 section 2.4 requires that when canonicalizing a document subset the namespace attributes from parent elements should be included in the subset root element. This PR adds support for this requirement.