Merge pull request #92 from russHyde/linting

Linting
russHyde · Apr 3, 2024 · 1191773 · 1191773
2 parents 8dec1ae + 302cf66
commit 1191773
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.lintr b/.lintr
@@ -9,6 +9,5 @@ linters: linters_with_defaults(
 exclusions: list(
   "inst/extdata/duplicated.R",
   "tests/testthat.R",
-  # ? should be able to exclude a directory in lintr
-  "tests/testthat/testdata/anRpackage/R/anRpackage-internal.R"
+  "tests/testthat/testdata"
   )
diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,7 @@
 
 * Update the CI workflows for pkgdown, test-coverage and R CMD check
 * use lintr >= 3, and update .lintr config file
+* Fixed linting across package
 * lint the package in CI
 * Convert default git branch to 'main' (#84, @russHyde)
 

diff --git a/R/dups-class.R b/R/dups-class.R
@@ -6,10 +6,11 @@ as_dups <- function(x) {
   if (methods::is(x, "dups")) {
     return(x)
   }
-  structure(
-    list(dups_df = x),
-    class = "dups"
-  )
+
+  dups <- list(dups_df = x)
+  class(dups) <- "dups"
+
+  dups
 }
 
 #' as.data.frame method for `dups` class