Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Encoding Issue #5

Closed
albu5 opened this issue Mar 8, 2018 · 3 comments
Closed

Encoding Issue #5

albu5 opened this issue Mar 8, 2018 · 3 comments

Comments

@albu5
Copy link

albu5 commented Mar 8, 2018

Charmap encoding errors while dumping scraped data into 'dataset/logs/google/source.html'. Explicitly mentioning encoding while opening the file using open() might be useful.
@rushilsrivastava
Copy link
Owner

rushilsrivastava commented Mar 10, 2018 •
edited
Loading

I think #6 will solve this issue. Awaiting @loopyd to make requested changes so I can merge.

@rushilsrivastava rushilsrivastava mentioned this issue Mar 10, 2018
Closed
rushilsrivastava added a commit that referenced this issue Mar 10, 2018
@rushilsrivastava
Patch for #5
9a07268
@loopyd
Copy link

loopyd commented Mar 10, 2018

Worked on it, its evolving into a feature update, though, so I closed that PR.

@rushilsrivastava
Copy link
Owner

Patched with 9a07268

@rushilsrivastava rushilsrivastava mentioned this issue Mar 10, 2018
Closed
@loopyd loopyd mentioned this issue Mar 10, 2018
Open
loopyd added a commit to loopyd/image-scrapers that referenced this issue Mar 11, 2018
@loopyd
correct patch (rushilsrivastava#5) for python 2.7
44d6e19
loopyd added a commit to loopyd/image-scrapers that referenced this issue Mar 11, 2018
@loopyd
Correct fix (rushilsrivastava#5)
903112e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albu5 @rushilsrivastava @loopyd