Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and fixes #45

Merged
merged 4 commits into from
Aug 17, 2019
Merged

Cleanup and fixes #45

merged 4 commits into from
Aug 17, 2019

Conversation

malturki
Copy link
Contributor

No description provided.

denis-bogdanas
denis-bogdanas approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@denis-bogdanas denis-bogdanas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after fixes to setHistoricalRootAccumulator().

In particular, function bytesValues() is not correct because there's no guarantee of the order of elements in a Map. The same conversion already existed in mapToList(), I moved it to types.k.

@denis-bogdanas denis-bogdanas merged commit 019a9cd into master Aug 17, 2019
@denis-bogdanas denis-bogdanas deleted the cleanupAndFixes branch August 23, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-bogdanas denis-bogdanas denis-bogdanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malturki @denis-bogdanas