Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cycles when forwarding requests #49

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

nknapp
Copy link
Contributor

@nknapp nknapp commented Mar 30, 2017

Closes #48

This commit adds a random header "x-npm-proxy-cache-"
to each requests send to the registry. It also rejects requests
with this header.
This is done to prevent "curl http://localhost:8080" from sending
the npm-proxy-cache into and endless loop of message-forwards.

Closes runk#48

This commit adds a random header "x-npm-proxy-cache-<random number>"
to each requests send to the registry. It also rejects requests
with this header.
This is done to prevent "curl http://localhost:8080" from sending
the npm-proxy-cache into and endless loop of message-forwards.
Copy link
Owner

@runk runk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runk runk merged commit 5ee765f into runk:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants