Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Create separate group for CV dependencies #882

Merged
merged 6 commits into from
Dec 17, 2024
Merged

chore(deps): Create separate group for CV dependencies #882

merged 6 commits into from
Dec 17, 2024

Conversation

setu4993
Copy link
Member

@setu4993 setu4993 commented Dec 17, 2024 •
edited
Loading

Shortcut: https://app.shortcut.com/galileo/story/23104/

Description: imagededup is producing a lot of pain for new installs, so making it optional for CV installs only, alongside a couple other CV exclusive dependencies.

Tests:

  • Local import (import dataquality as dq with all extras uninstalled).
  • CI.

@setu4993 setu4993 requested a review from a team as a code owner December 17, 2024 02:07
@setu4993
Copy link
Member Author

https://app.shortcut.com/galileo/story/23104/dq-remove-imagededup-dependency-for-dq

dmallon
dmallon approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dmallon dmallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

bogdan-galileo
bogdan-galileo approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bogdan-galileo bogdan-galileo left a comment •
edited by setu4993
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That imagededup was terrible, it was downloading a small pytorch model at install time, and it created issues with customers which were not allowed to download models.

@setu4993 setu4993 merged commit e8782d2 into main Dec 17, 2024
3 checks passed
@setu4993 setu4993 deleted the chore/deps/imagededup-optional branch December 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan-galileo bogdan-galileo bogdan-galileo approved these changes

@dmallon dmallon dmallon approved these changes

@franz101 franz101 Awaiting requested review from franz101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@setu4993 @dmallon @bogdan-galileo