feat: add tests for special IP in --add-host flag #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
pendo324
reviewed
Feb 13, 2023
IMO, whether it goes into common-tests depends on if it is part of common container development workflow instead of Finch special thing. Special IP is in Docker now and is being added to nerdctl. So I think it is fine to add to common-tests. |
pendo324
approved these changes
Feb 13, 2023
ningziwen
pushed a commit
that referenced
this pull request
Feb 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2023-02-13) ### Features * add tests for special IP in --add-host flag ([#29](#29)) ([1fecd9f](1fecd9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ningziwen
added a commit
to runfinch/finch
that referenced
this pull request
Feb 13, 2023
Issue #, if available: #209 *Description of changes:* Support special IP `host-gateway` in `--add-host` flag. Finch will resolve to the IP that can be used to access host from containers. It is not configurable for now. See [issue](#209) for more details. *Testing done:* unit tests and e2e tests runfinch/common-tests#29 - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziwen Ning ningziwe@amazon.com
Issue #, if available:
runfinch/finch#209
Description of changes:
Start a server in host and try to curl it from container with
--add-host test-host:host-gatewayTesting done:
make runwith the change runfinch/finch#216License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.