Fix next execution time on non-scheduled cluster member #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger.getNextFireTime() returns null if the trigger hasn't been added to a schedule (or more precisely, if the start time hasn't been set yet). This meant that in a clustered rundeck installation, the non-scheduled cluster member would show jobs as being scheduled "never". Using trigger.getFireTimeAfter() will properly calculate the next execution
|
thanks! |
gschueler
added a commit
that referenced
this pull request
Jul 2, 2015
Fix next execution time on non-scheduled cluster member
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a clustered rundeck installation, the cluster member that isn't the assigned node for a job will display "never" for the next scheduled execution time.
This turns out to be because
trigger.getNextFireTime()returnsnullif the trigger hasn't been added to a schedule (or more precisely, if the start time hasn't been set yet). Usingtrigger.getFireTimeAfter(new Date())will properly calculate the next execution.