Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github generated PR message for merge commits #939

Closed
wants to merge 1 commit into from

Conversation

pratikmallya
Copy link
Contributor

@pratikmallya pratikmallya commented Mar 2, 2020

  • pull in latest version of go-github
  • fix unit tests

Fixes: #845

@pratikmallya
Copy link
Contributor Author

@lkysow a bit unsure about how I would update to use the latest version of go-github.... the naive go get seems to fail with:

$ go get -u github.com/google/go-github@master
go: finding github.com/google/go-github master
go: finding github.com/google/go-github master
go get github.com/google/go-github@master: github.com/google/go-github@v0.0.0-20200302001034-5f66efb9dc28: invalid version: go.mod has post-v0 module path "github.com/google/go-github/v29" at revision 5f66efb9dc28

@lkysow
Copy link
Member

lkysow commented Mar 2, 2020

Do we need to use import github.com/google/go-github/v29/github?

@lkysow lkysow added the waiting-on-response Waiting for a response from the user label Mar 13, 2020
@lkysow
Copy link
Member

lkysow commented May 25, 2020

Closing in favour of #1049

@lkysow lkysow closed this May 25, 2020
@pratikmallya
Copy link
Contributor Author

Thanks @lkysow ! Apologies, got distracted with other things and totally dropped the ball here.

@pratikmallya pratikmallya deleted the issue-845 branch June 1, 2020 14:08
@lkysow
Copy link
Member

lkysow commented Jun 1, 2020

No worries! I didn't test it out myself so hopefully it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve original commit message when auto-merging
2 participants