feat: migrate to use pnpm and add sitemapPlugin #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
|
netlify side needs some config change per this PR
|
add `vue` and `@vuepress/client` as peer-dependencies stick with node 20 update @vuepress/plugin-docsearch dep with `npx vp-update` add vuepress-plugin-sitemap2 plugin Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
pnpm-sitemapPlugin
branch
from
9bd5133 to
0f17313
Compare
chenrui333
requested review from
lukemassa and
X-Guardian
and removed request for
a team
jamengual
approved these changes
Feb 8, 2024
|
/cherry-pick release-0.27.1 |
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
* migrate off yarn to pnpm add `vue` and `@vuepress/client` as peer-dependencies stick with node 20 update @vuepress/plugin-docsearch dep with `npx vp-update` add vuepress-plugin-sitemap2 plugin Signed-off-by: Rui Chen <rui@chenrui.dev> * replace yarn.lock with pnpm-lock.yaml for labeler Signed-off-by: Rui Chen <rui@chenrui.dev> * replace yarnDedupeHighest with pnpmDedupe for renovate Signed-off-by: Rui Chen <rui@chenrui.dev> * update website-lint job Signed-off-by: Rui Chen <rui@chenrui.dev> --------- Signed-off-by: Rui Chen <rui@chenrui.dev>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
* migrate off yarn to pnpm add `vue` and `@vuepress/client` as peer-dependencies stick with node 20 update @vuepress/plugin-docsearch dep with `npx vp-update` add vuepress-plugin-sitemap2 plugin Signed-off-by: Rui Chen <rui@chenrui.dev> * replace yarn.lock with pnpm-lock.yaml for labeler Signed-off-by: Rui Chen <rui@chenrui.dev> * replace yarnDedupeHighest with pnpmDedupe for renovate Signed-off-by: Rui Chen <rui@chenrui.dev> * update website-lint job Signed-off-by: Rui Chen <rui@chenrui.dev> --------- Signed-off-by: Rui Chen <rui@chenrui.dev> Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
initially was just thinking to include the
vuepress-plugin-sitemap2plugin, but it does not support yarn 1.x (aka classic yarn), thus migrating to use pnpm (latest and greatest nodejs package manager), and include/update dependencies (per the vuepress 2.x doc, needs to include some peer dependencies,vueand@vuepress/client)why
trying to add sitemap.xml support for SEO
tests
pnpm installpnpm website:devpnpm website:buildwebsite:buildrunreferences