Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the fast mode flag #196

Closed
wants to merge 2 commits into from
Closed

Add the fast mode flag #196

wants to merge 2 commits into from

Conversation

hexapode
Copy link
Member

No description provided.

@@ -65,6 +65,10 @@ class LlamaParse(BasePydanticReader):
default=None,
description="The API key for the GPT-4o API. Lowers the cost of parsing.",
)
fast_mode: bool = Field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this conflict with result_type ? Now I can set result_type="markdown" and fast_mode=True and not get markdown?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove/deprecated result_type? As we do not have the functionality on the API? other idea @logan-markewich ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there is a result type, it's part of the request url?

And there's still a conflict between that type and this fast mode. Seems like fast mode should just be another result type, like result_type="text-fast"

Otherwise, there would be conflicts between the two params

@hexapode hexapode closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants