RUN-20790 Impersonate dummy dcgm exporter on fake nodes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gshaibi
commented
Nov 27, 2024
gshaibi
commented
- Samples
- [status-updater] Populate impersonation configuration to the exporter
- Enrich with prometheus labels
- Refactor metrics initialization and update tolerations in status exporter
gshaibi
force-pushed
the
shaibi/RUN-20790-kwok-metrics-impersonate-dummy-dcgm-exporter
branch
from
0bee59f to
0898b6d
Compare
gshaibi
changed the title
…i/RUN-20790-kwok-metrics-impersonate-dummy-dcgm-exporter
gshaibi
force-pushed
the
shaibi/RUN-20790-kwok-metrics-impersonate-dummy-dcgm-exporter
branch
from
575dbef to
76baacd
Compare
gshaibi
changed the title
noaamran
approved these changes
Dec 2, 2024
|
Closing this PR as the current need and motivation do not justify the associated risks and added code complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.