Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: add packagingOptions to build.gradle #244

Closed

Conversation

quocb
Copy link

@quocb quocb commented Apr 19, 2023

Description of changes

Adding packagingOptions to build.gradle for issue #228 2 files found with path 'lib/arm64-v8a/libc++_shared.so' from inputs:

   packagingOptions {
        pickFirst 'lib/x86/libc++_shared.so'
        pickFirst 'lib/x86_64/libjsc.so'
        pickFirst 'lib/arm64-v8a/libjsc.so'
        pickFirst 'lib/arm64-v8a/libc++_shared.so'
        pickFirst 'lib/x86_64/libc++_shared.so'
        pickFirst 'lib/armeabi-v7a/libc++_shared.so'
    }

I did Exploratory testing:

  • android
  • ios

Can it be published to NPM?

  • Breaking change
  • Documentation is updated

@@ -26,6 +26,14 @@ android {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
packagingOptions {
pickFirst 'lib/x86/libc++_shared.so'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://developer.android.com/reference/tools/gradle-api/7.4/com/android/build/api/dsl/PackagingOptions#pickFirst(kotlin.String) it is deprecated now. Also any chance to investigate why it doesn't work for you if you do it in the host app?

@rumax rumax closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants