Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sliding sync to latest #1273

Merged
merged 18 commits into from
Sep 21, 2022
Merged

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Aug 31, 2022

This adds support for the latest spec proposal updates of MSC 3575 ("Sliding Sync") for:

  • tags and not_tags filters
  • resolve_tombstones flag
  • limited, joined_count and invited_count responses taken over from v3

This also adds the current state of existing extensions. These are not yet specified, even within the proposal but are not likely to change much going forward. Those are:

  • ToDevice Messages
  • End-to-end-encryption messages
  • AccountData, globally as well as for specific rooms.

This is all still behind the same feature-flag as before.


Preview Removed

@gnunicorn gnunicorn requested a review from jplatte August 31, 2022 16:05
crates/ruma-client-api/CHANGELOG.md Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
crates/ruma-client-api/src/sync/sync_events/v4.rs Outdated Show resolved Hide resolved
@gnunicorn gnunicorn force-pushed the ben-update-sliding-sync branch from af24143 to 999a70f Compare September 19, 2022 11:03
@jplatte jplatte changed the title Updating sliding sync to latest Update sliding sync to latest Sep 19, 2022
@jplatte
Copy link
Member

jplatte commented Sep 19, 2022

Ah, I thought you adressed all review comments and we could merge with that one extra change. Looks like one last change (pub use) and re-format is still needed.

@gnunicorn
Copy link
Contributor Author

No, I had to do fixes for the currently buggy proxy-implementation. Not entirely sure if we want to merge that as is... your call.

@jplatte
Copy link
Member

jplatte commented Sep 20, 2022

It's an unstable feature, so I'm happy to merge after the breaking change to the stable API is fixed (DeviceLists not being exported from sync_events::v3).

@gnunicorn
Copy link
Contributor Author

weird, I made the change, but looks like I forgot to merge.

however, meanwhile the proxy bug is supposedly fixed. So let me confirm that and remove the hacks...

@gnunicorn gnunicorn marked this pull request as draft September 21, 2022 10:40
@gnunicorn gnunicorn marked this pull request as ready for review September 21, 2022 16:04
@gnunicorn gnunicorn requested a review from jplatte September 21, 2022 16:05
@jplatte jplatte merged commit efc5e61 into ruma:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants