Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof of concept for #153 "Treasure hunt mode" #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janScheible
Copy link
Contributor

I was searching for a simple app to do a treasure hunt. I found this issue in GetBack GPS and wanted to give it a try. :-)
Perhaps this is possible way to go to add such a feature to the codebase.

  • re-uses as much as possible of the destination reached logic and the presentation in the UI
  • MainActivity
    • as soon as the destination is reached and a certain dwell time (currently 5s) elapsed the next hunt destination is set
  • AbstractGetBackGpsActivity
    • HUNT_DESTINATIONS is a hard-coded list of hunt destinations
      • TODO provide a UI for the hunt destinations (that would better fit to Multiple consecutive destinations #154 "Multiple consecutive destinations" because the user sees the locations)
        • alternatively fetch them from some server to hide the from the user, but that would required Internet access permissions
    • huntDestinations holds the remaining hunt destinations (or non at all if not in treasure hunt mode)
    • a new menu item to start treasure hunt (hard-coded English menu text for now)

- re-uses as much as possible of the destination reached logic and the presentation in the UI
- `MainActivity`
-- as soon as the destination is reached and a certain dwell time (currently 5s) elapsed the next hunt destination is set
- `AbstractGetBackGpsActivity`
-- `HUNT_DESTINATIONS` is a hard-coded list of hunt destinations
--- TODO provide a UI for the hunt destinations (that would better fit to ruleant#154 "Multiple consecutive destinations" because the user sees the locations)
---- alternatively fetch them from some server to hide the from the user, but that would required Internet access permissions
-- `huntDestinations` holds the remaining hunt destinations (or non at all if not in treasure hunt mode)
-- a new menu item to start treasure hunt (hard-coded English menu text for now)
@ruleant
Copy link
Owner

ruleant commented Jan 31, 2022

Hi @janScheible

Thanks for yet another PR, although it is a Proof of Concept.
After having a quick look at the code, it looks like your POC can work. :)
I like the way you used the isDestinationReached() status to switch to the next destination.

I agree with your remarks you mention, regarding making the HUNT_DESTINATIONS configurable. Ideally there should be a way to export/import them, or make them somehow downloadable, plenty of possibilties to achieve this. I have some ideas there as well, but those are things that can be build on after a working base is implemented.
This POC seems like a small project with a set of sub-issues to work on.

I guess we'll need a local SQLite database to store mulitple locations (this is on my to do list for some time now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants