Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client and deprecate useless features #149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pedrobranco
Copy link
Collaborator

@pedrobranco pedrobranco commented Jul 31, 2023

This pull request includes several updates and improvements to the codebase, focusing on updating dependencies, removing deprecated features, and adding support for new Bitcoin Core methods. The most important changes include updating the Node.js versions in the CI configuration, modifying the README.md to reflect new usage instructions, and updating the Docker and package configurations to support the latest Bitcoin Core versions.

Updates and Improvements:

  • CI Configuration:

    • Updated Node.js versions in the GitHub Actions workflow to include the latest versions (20, 22). (.github/workflows/tests.yaml)
  • Documentation:

    • Simplified the README.md by removing outdated SSL/TLS connection examples and updating the usage instructions to reflect the new default values and removed options. (README.md) [1] [2] [3] [4]
  • Docker Configuration:

    • Updated Docker images to use the latest Bitcoin Core version (28.0) and adjusted related configurations for better compatibility and security. (docker-compose.yml) [1] [2]
  • Package Configuration:

    • Removed deprecated services from the Docker Compose configuration and updated the dependencies script in package.json to reflect these changes. (package.json)
  • Codebase Simplification:

    • Removed network-specific configurations and SSL options from the Client class, simplifying the connection setup process. (src/index.js) [1] [2] [3] [4]
    • Added support for new Bitcoin Core methods, including createWalletDescriptor, descriptorProcessPsbt, enumerateSigners, getAddrManInfo, getBlockFromPeer, getChainStates, getHdKeys, getPrioritisedTransactions, getTxSpendingPrevOut, importMempool, loadTxOutSet, migrateWallet, newKeyPool, psbtBumpFee, scanBlocks, scanTxOutSet, send, and sendAll. (src/methods.js) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

@pedrobranco pedrobranco force-pushed the enhancement/improve-client branch 2 times, most recently from 91b24cd to eb1054b Compare July 31, 2023 15:16
@pedrobranco pedrobranco force-pushed the enhancement/improve-client branch from eb1054b to 38cea64 Compare November 25, 2024 14:53
@pedrobranco pedrobranco force-pushed the enhancement/improve-client branch from 4bb315a to 73ccd8a Compare November 25, 2024 15:02
@pedrobranco pedrobranco marked this pull request as ready for review November 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant