Skip to content

Commit

Permalink
Enable -Wimplicit-fallthrough in f5b/PACKAGE (facebookincubator#8799)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookincubator#8799

This diff enables the titular warning flag for the directory in question. Further details are in [this workplace post](https://fb.workplace.com/permalink.php?story_fbid=pfbid02XaWNiCVk69r1ghfvDVpujB8Hr9Y61uDvNakxiZFa2jwiPHscVdEQwCBHrmWZSyMRl&id=100051201402394).

This is a low-risk diff. There are **no run-time effects** and the diff has already been observed to compile locally. **If the code compiles, it works; test errors are spurious.**

If the diff does not pass, it will be closed automatically.

Reviewed By: dmm-fb

Differential Revision: D53545504

fbshipit-source-id: f1f54e6d085e79358b07696dbdb8e4b7fdb291cf
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 19, 2024
1 parent f31c8ac commit d55c48b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/experimental/codegen/ast/ASTNode.h
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ class ASTNode {
return;
}
}
setMaybeNull(false);
return;
case ExpressionNullMode::NotNull:
setMaybeNull(false);
return;
Expand Down

0 comments on commit d55c48b

Please sign in to comment.