Fix for error AuthorizedKeysCommand signal 13 #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before, the sshd exits when finds the key already matches, while the bash script still is in the process printing out all of the keys. When this happened, the sshd kills the pipe, and so bash script gets an
error signal 13. Sshd then still checks the return value, and since it is> 0it stops the login. This issue occurred to only some users (probably somehow connected with the ssh client version), but for those it was approximately quarter sessions failed.The proposed solution wraps the script's last part, where only the key printing is happening. It catches any problematic output and exits gracefully.
Running longer test over weekend, ended up in 47 errored out of 90k successful connections.
Deployed on Hyperchicken ✔️