Added missing functionality for Samba shares. #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pneerincx
commented
Oct 21, 2022
pneerincx
commented
- Added code to create path for Samba shares if it does not already exist.
- Updated Copper Fist and Beta Barrel group_vars for recently updated functionality.
…st. Updated Copper Fist and Beta Barrel group_vars for recently updated functionality.
pneerincx
requested review from
scimerman,
Gerbenvandervries and
marieke-bijlsma
roles/smb_server/tasks/main.yml
Outdated
|
|
||
| - name: Fail if base path for a samba share is missing. | ||
| ansible.builtin.fail: | ||
| msg: "The base path {{ item['base'] }} is missing for samba share {{ item['name'] }}. Another role role should have been deployed first or your config is incomplete." |
There was a problem hiding this comment.
Sentence contains word "role" twice
marieke-bijlsma
requested changes
Oct 21, 2022
marieke-bijlsma
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.