Irods and davrods: bigger update #3 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bots into irods_and_davrods
…dated variables, rewrite database_connect.py, increased davrods security/tls> v1.2 and limited ciphers ...
pneerincx
reviewed
Aug 11, 2022
pneerincx
reviewed
Aug 11, 2022
Comment on lines
+12
to
20
| # - name: Upgrade pip to latest version | ||
| # ansible.builtin.command: pip3 install -U pip | ||
| # become: true | ||
| - name: Upgrade pip3 to latest version | ||
| ansible.builtin.pip: | ||
| name: pip | ||
| state: latest | ||
| executable: pip3 | ||
| become: true |
There was a problem hiding this comment.
This will overwrite the version installed with the RPM using ansible.builtin.yum. Hence this cannot be "frozen" using the Pulp repos and could break other Python3 RPMs. Is this necessary? Or is the python3-pip RPM installed with ansible.builtin.yum good enough?
There was a problem hiding this comment.
There are a few other Python packages installed with pip3 and without version control:
- Install docker-py (supported by python 3)
- Install pyodbc with pip3
Can those be deployed in a python virtual environment for iRODS as opposed to in the default location affecting all Python code on the server?
pneerincx
requested changes
Aug 11, 2022
…ue-of-robots into irods_and_davrods
…bots into irods_and_davrods
…ue-of-robots into irods_and_davrods
…bots into irods_and_davrods
…bots into irods_and_davrods
…ue-of-robots into irods_and_davrods
pneerincx
reviewed
Sep 2, 2022
| ansible.builtin.command: sudo python /var/lib/irods/scripts/setup_irods.py --json_configuration_file=/root/unattended_install.json | ||
| when: database_tables.stdout_lines | default([]) | length > 0 and database_tables.stdout is search(".*No relations found.*") | ||
| ansible.builtin.command: 'python /var/lib/irods/scripts/setup_irods.py --json_configuration_file=/{{ ir_service_account_home }}/unattended_install.json' | ||
| # when: database_tables.stdout_lines | default([]) | length > 0 and database_tables.stdout is search(".*No relations found.*") |
There was a problem hiding this comment.
Is this as intended or was the when commented out for testing purposes?
pneerincx
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unixODBC-devel,python3-develandgcc-c++packages so that pyodbc can be built when installed with pipdatabase_connect.pyto use generic/internal irods configuration values (moved to files, as it should work with "native" settings and we will not need our ansible variables anymore - created upstream pull request)yum updatedocker-pyto support the python 3, as the 2 was problematic for deploy (and of course, it is outdated ... )Tested on irods-test ✔️ , deployed on irods-catalogus ✔️
Irods iput, irm tested ✔️ , davrods access tested ✔️
Checked with lattest ansible-lint (6.4.0) ✔️