-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iRODS: v2 (remote pgsql, tiering, bugfixes, variables and new certificate) #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, large PR :) Looks mostly good. A few minor issues/suggestions. See inline comments.
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 2 more inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small YAML indentation issue in playbook; see inline comment.
icat.yml
into_pre
configuration and main configurationpgsql_remote.yml
playbook, to configure icat to use remote sql servertemplates/database_connect.py
- used only on irods-server version 4.2.11) to correctly use the ssl when using remote pgsql serverpgsql.yml
into postgres_local
, as to differentiate from thepgsql_remote.yml
icat_
andirods_
to avoid confusionirods_
variable are now shortened toir_
to save space and avoid further confusionstatic_inventory
secrets.yml
, f.e. instatic_inventories/nibbler_cluster.yml
(followed the convention of intermediate certificates order - sorted them correctly)
docker-compose
andServerName
invhost.conf
ended in error due to new docker version