Jenkins #579
Merged
Jenkins #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-robots into develop Pulled jenkins changes from mbijlsma.
…bots into develop Regular pull from blessed develop.
…XY when it is defined but an empty string.
…hen a stack does not have a jumphost listed in its static inventory.
…ack_name Ansible variable instead of slurm_cluster_name as not all stacks are slurm clusters and hence some do not use slurm_cluster_name.
…ct what this play is actually doing.
marieke-bijlsma
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins work:
geerlingguy.javain favor of a simpleyumtask.geerlingguy.jenkinsas it is currently broken: role creates config files for old style system V service, but Jenkins now usessystemd, which must be configured differently.warnings-ngssl.conf, so we can use Apache httpd as proxy.Miscellaneous bugfixes for issues that emerged during testing:
inventory_plugins/yaml_with_jumphost.py: do not use${AI_PROXY}when it is defined but an empty string.lor-init: do not set${AI_PROXY}env var to an empty string when a stack does not have a jumphost listed in its static inventory.single_group_playbooks/pre_deploy_checks.yml: check forstack_nameAnsible variable instead ofslurm_cluster_nameas not all stacks are slurm clusters anymore and hence some do not useslurm_cluster_name.single_role_playbooks/firewall.yml: changed wrong name/title to reflect what this play is actually doing.