Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WH: NFS fix #575

Merged
merged 2 commits into from
May 16, 2022
Merged

WH: NFS fix #575

merged 2 commits into from
May 16, 2022

Conversation

scimerman
Copy link
Contributor

Added into static inventories the missing nfs_server for Wingedhelix cluster

@scimerman scimerman requested a review from pneerincx May 16, 2022 11:29
Copy link
Contributor

@pneerincx pneerincx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to also add the nfs_server group to the wingedhelix_cluster group at the bottom of the inventory file. In the current situation it will work without nfs_server being listed there, because we put that functionality on wh-sai, which is already included in the wingedhelix_cluster group as part of cluster, which contains administration, which contains sys_admin_interface. But if the NFS server functionality would be relocated to another dedicated machine it would fail if it is not explicitly included in the wingedhelix_cluster group.

@scimerman
Copy link
Contributor Author

I think it is better to also add the nfs_server group to the wingedhelix_cluster group at the bottom of the inventory file. In the current situation it will work without nfs_server being listed there, because we put that functionality on wh-sai, which is already included in the wingedhelix_cluster group as part of cluster, which contains administration, which contains sys_admin_interface. But if the NFS server functionality would be relocated to another dedicated machine it would fail if it is not explicitly included in the wingedhelix_cluster group.
You are correct. Without defining it in the cluster, it would never be called by cluster.yml. I have fixed it. Thanks.

@pneerincx pneerincx merged commit c0050d7 into rug-cit-hpc:develop May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants