Latest version class #897
Latest version class #897
Conversation
|
I like the Latest as it always refers to the dependency in the README file. Hopefully the ES API does not change every time. This could even be mentioned in the doc block of Latest. |
|
I would merged this pull request, if there are no objections. |
|
What exactly do you want to mention in the comments? |
|
That Latest references to the version mentioned in the README.md file. Like this it is always clear which one is meant as the README is also versioned and it is not confused with the latest version of elasticsearch. |
|
I had a small log in the comment, but deleted it because it would require changing this file on every release. I could add it again /*
* no changes since 1.4.0:
* - 1.5.0 (March 23, 2015)
* - 1.6.0 (June 09, 2015)
* - 1.7.0 (July 16, 2015)
*/ |
| /** | ||
| * Latest elasticsearch DSL. | ||
| * | ||
| * @link https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html |
There was a problem hiding this comment.
@webdevsHub Here I would add a comment: Latest always refer to the version mentioned in README.md
Like this it never has to be updated here :-)
|
See my comment in the code. I would leave out the comment that has to be changed every time. |
|
comment added |
|
Merged. Thx. |
description of this PR: #893
another option would be to just use
Version140as defaultQueryBuilderversion withoutLatestclass but it could be misunderstood as "Elastica is outdated".I will add changelog entry after discussion.