Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for percentiles aggregation #786

Merged
merged 1 commit into from
Feb 19, 2015

Conversation

im-denisenko
Copy link
Contributor

Percentiles aggregation was available since ES 1.1, but still marked as experimental.
But like scripted metrics in #780, I need it and thought maybe you want to merge :)

@im-denisenko
Copy link
Contributor Author

Btw, anyone who has older version of elastica and wants to use not implemented aggregation (just like me today), they can use following workaround. It's less hardcore than raw array query:

$query = new Elastica\Query();
$query->setFilter(/* blah blah */);
$query->setQuery(/* blah blah */);
$query->setParam('aggs', [
    'price_percentiles' => [
        'percentiles' => [
            'field' => 'price',
        ],
    ],
]);

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 84.13% when pulling c69a1f2 on im-denisenko:feature/percentiles-aggregation into bfa9363 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.37% when pulling c69a1f2 on im-denisenko:feature/percentiles-aggregation into bfa9363 on ruflin:master.

ruflin added a commit that referenced this pull request Feb 19, 2015
…tion

Add support for percentiles aggregation
@ruflin ruflin merged commit 7f62b40 into ruflin:master Feb 19, 2015
@ruflin
Copy link
Owner

ruflin commented Feb 19, 2015

Merged. It would probably make sense to have your comment above as documentation on Elastica.io.

@im-denisenko im-denisenko deleted the feature/percentiles-aggregation branch February 20, 2015 06:10
@im-denisenko
Copy link
Contributor Author

With my english level, some text longer than PR message, always looks terrible.
I can have a try in near future, just don't wait for this soon.

@ruflin
Copy link
Owner

ruflin commented Feb 21, 2015

@im-denisenko No worries about your english. We all make some mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants