Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StrategyFactory.php #730

Closed
wants to merge 1 commit into from
Closed

Conversation

konformjs
Copy link

added false to class_exists to prevent autoloader to run

added false to class_exists to prevent autoloader to run
@ruflin
Copy link
Owner

ruflin commented Dec 9, 2014

@konformjs Thank you for the addition. Did you see the discussion here? #721

@konformjs
Copy link
Author

No but I can see it’s not so simple. But thank you for your great library

Best regards

jesper

From: Nicolas Ruflin [mailto:notifications@github.com]
Sent: 9. december 2014 19:46
To: ruflin/Elastica
Cc: Jesper Sandberg
Subject: Re: [Elastica] Update StrategyFactory.php (#730)

@konformjshttps://github.com/konformjs Thank you for the addition. Did you see the discussion here? #721#721


Reply to this email directly or view it on GitHubhttps://github.com//pull/730#issuecomment-66334465.

@ruflin
Copy link
Owner

ruflin commented Dec 18, 2014

@konformjs As nobody opened the pull request yet for the other change, perhaps you can adapt yours so that it fits?

@im-denisenko
Copy link
Contributor

Fixed via #877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants