Fix collision of Elastica\Type and Elastica\Filter\Type in \Elastica\Filter\Ids #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't see an advantage of the one over the other. Can you add a small test for this so we make sure someone does not change it back in the future again? |
|
Hi, just done so, the test is kind of silly but does the work. |
|
Agree, but it works :-) Probably it needs a short comment in the test, why this test is here ... |
ruflin
added a commit
that referenced
this pull request
Aug 8, 2013
Fix collision of Elastica\Type and Elastica\Filter\Type in \Elastica\Filter\Ids
|
Thx merged. |
|
No problem! Anytime :) 2013/8/8 Nicolas Ruflin notifications@github.com
|
simon-n
pushed a commit
to simon-n/Elastica
that referenced
this pull request
May 30, 2016
simon-n
pushed a commit
to simon-n/Elastica
that referenced
this pull request
May 30, 2016
merk
added a commit
that referenced
this pull request
May 30, 2016
adapted Type namespace collision fix for Query\Ids, see PR #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when using Elastica\Filter\Type this error shows: Cannot use Elastica\Type as Type because the name is already in use.
This fixes the collision in Elastica\Filter\Ids between Elastica\Type and Elastica\Filter\Type
If it's better that we switch to Elastica\Filter insted of use as ElasticaFilter, tell me and I'll resubmit the PR.
Cheers