Deprecate passing string to Search::addIndex, hasIndex and addIndices
#2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePanz
reviewed
Jul 22, 2022
src/Search.php
Outdated
| public function addIndicesByName(array $indices = []): self | ||
| { | ||
| foreach ($indices as $index) { | ||
| $this->addIndexByName($index); |
There was a problem hiding this comment.
we should check if $index is really a non-empty string
thePanz
requested changes
Jul 22, 2022
thePanz
force-pushed
the
deprecate_wrong_types
branch
from
3589e50
to
066c5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2100 (comment)
Right now
Search::addIndex()andSearch::hasIndex()methods allowstring|Indexas parameter andSearch::addIndices()allows an array ofIndexorstring.This PR creates
Search::addIndexByName()andSearch::hasIndexByName()which only allowsstringas parameter andSearch::addIndicesByName()which only accepts an array ofstring.This PR also deprecates passing
stringtoSearch::addIndex(),Search::hasIndex()andSearch::addIndices().