Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Query::create parameter types #2088

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Update Query::create parameter types #2088

merged 1 commit into from
Jun 24, 2022

Conversation

franmomu
Copy link
Contributor

It was triggered by

Elastica/tests/Suggest/TermTest.php

Lines 125 to 129 in a0a2dc2

$termSuggest = new Term('suggest1', 'text');
$termSuggest->setText('Foobar')->setSize(4);
$index = $this->_getIndexForTest();
$result = $index->search($termSuggest);

where a Term (AbstractSuggest) is passed to Index::search().

@ruflin ruflin merged commit cd552e1 into ruflin:master Jun 24, 2022
@franmomu franmomu deleted the query_phpdoc branch June 24, 2022 17:57
jhuebner79 pushed a commit to jhuebner79/Elastica that referenced this pull request Jun 26, 2022
@franmomu @jhuebner79
Update Query::create parameter types (ruflin#2088)
8a20581
jhuebner79 pushed a commit to jhuebner79/Elastica that referenced this pull request Jun 26, 2022
@franmomu @jhuebner79
Update Query::create parameter types (ruflin#2088)
510e1c6
jhuebner79 pushed a commit to jhuebner79/Elastica that referenced this pull request Jun 26, 2022
@franmomu @jhuebner79
Update Query::create parameter types (ruflin#2088)
262092b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @ruflin