Remove 0 as request data

[franmomu]

Checking errors found by PHPStan, there is this one, here the thing is that Request::getData() is supposed to return an array:

Elastica/src/Request.php

Lines 84 to 92 in 72a4598

	/**
	* Return request data.
	*
	* @return array Request data
	*/
	public function getData()
	{
	return $this->getParam('data');
	}

This was added in #640 (8 years ago) and the test was removed in #932.

So I don't know if the 0 is a possible value so we should modify the return type of Request::getData() or this can be removed.

[ruflin]

@Tobion @leabaertschi I know #640 is years ago but do you remember by chance why we needed this and if it still applies today?

[leabaertschi]

Sorry, I don't remember, I haven't worked with elasticseach in years.

[ruflin]

I did a quick test. I think the following was working in old versions of Elasticsearch for analyze: https://www.elastic.co/guide/en/elasticsearch/reference/1.7/indices-analyze.html

curl -X GET "http://elastic:changeme@localhost:9200/_analyze?pretty" -H 'Content-Type: application/json' -d'0'

Looking at the current docs, it seems it is always an object that is expected: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html

Lets move forward with this.

@franmomu Can you add a changelog entry? Thanks for the cleanup.

[franmomu]

done, thanks for checking into this!

[thePanz]

Merged @franmomu , thanks!