Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version/version_type options from Index::addDocument() #2050

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

pidera
Copy link
Contributor

@pidera pidera commented Jan 15, 2022

As mentioned in #2049, the version/version_type has been removed in 7.x as concurrency control.

These options were still always added in the addDocument method which causes an issue when adding a document from one index to another.

This PR removes those options, and sorts the other options alphabetically cfr #1803.

@ruflin
Copy link
Owner

ruflin commented Jan 17, 2022

Thanks for the cleanup @pidera Any chance you could add an entry to the changelog?

Is my understanding correct that the test you added would not have passed without the change?

@pidera
Copy link
Contributor Author

pidera commented Jan 17, 2022

@ruflin I have added the changelog entry. And indeed, the added test did not pass without the change!

@ruflin ruflin merged commit 4380afd into ruflin:master Jan 18, 2022
@ruflin
Copy link
Owner

ruflin commented Jan 18, 2022

Thanks for the contribution @pidera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants