Deprecate wrong buckets_path initialization on bucket aggregations #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
aggregation-buckets-path-deprecations
branch
4 times, most recently
from
a9fe831 to
a9e7cb6
Compare
deguif
force-pushed
the
aggregation-buckets-path-deprecations
branch
2 times, most recently
from
773deaf to
f48cacb
Compare
deguif
force-pushed
the
aggregation-buckets-path-deprecations
branch
from
2e21635 to
5e02bed
Compare
ruflin
approved these changes
Dec 7, 2021
| @@ -19,6 +19,10 @@ public function __construct(string $name, ?string $bucketsPath = null, ?string $ | |||
|
|
|||
| if (null !== $bucketsPath) { | |||
There was a problem hiding this comment.
It seems the top part of the constructor is always shared. Made me wonder if we should extract it.
There was a problem hiding this comment.
Yes it's shared by a lot of pipeline aggregation, but there're some exceptions like bucket_script or bucket_selector which accepts an array of buckets paths.
A topic I have in mind for 8.0 version is to review the aggregations classes to separate them in three categories (as described in https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations.html) pipeline, metric and bucket as they have some difference (for example a pipeline aggregation can't have sub aggregations, ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.