Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use params to configure terms query #2032

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Use params to configure terms query #2032

merged 4 commits into from
Dec 2, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Dec 2, 2021

Fix #2031

@deguif deguif self-assigned this Dec 2, 2021
@deguif deguif mentioned this pull request Dec 2, 2021
Closed
ruflin
ruflin approved these changes Dec 2, 2021
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. It not only fixes a bug but also simplifies the code!

I have the suspicion the same could be done to other classes to. We used a lot of private variables before the introduce of setParams.

@deguif deguif merged commit 89d3867 into ruflin:master Dec 2, 2021
@deguif deguif deleted the terms-params branch December 2, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the post_filter is unset in Query if Terms is used post_filter
2 participants
@deguif @ruflin