Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bool, float, int in field params values for match phrase query #1944

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Allow bool, float, int in field params values for match phrase query #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc471b
Allow bool, float, int in field params values for match phrase query
deguif Mar 23, 2021
646e01e
Add changelog
deguif Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased](https://github.com/ruflin/Elastica/compare/7.1.0...master)
### Backward Compatibility Breaks
* Changed `Elastica\Query\MatchQuery::setFieldParam()` signature to allow passing bool, float or int [#1941](https://github.com/ruflin/Elastica/pull/1941)
* Changed `Elastica\Query\MatchPhraseQuery::setFieldParam()` signature to allow passing bool, float or int [#1944](https://github.com/ruflin/Elastica/pull/1944)
### Added
### Changed
* Changed `Elastica\Status::indexExists()`, `Elastica\Status::aliasExists()` and `Elastica\Status::getIndicesWithAlias()` signatures [#1929](https://github.com/ruflin/Elastica/pull/1929)
Expand Down
4 changes: 3 additions & 1 deletion src/Query/MatchPhrase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ public function setField(string $field, $values): self
/**
* Sets a param for the given field.
*
* @param bool|float|int|string $value
*
* @return $this
*/
public function setFieldParam(string $field, string $key, string $value): self
public function setFieldParam(string $field, string $key, $value): self
{
if (!isset($this->_params[$field])) {
$this->_params[$field] = [];
Expand Down