Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call_user_func() by direct calls #1923

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Replace call_user_func() by direct calls #1923

merged 2 commits into from
Mar 17, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Mar 17, 2021

No description provided.

@deguif deguif self-assigned this Mar 17, 2021
ruflin
ruflin approved these changes Mar 17, 2021
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful new world

@deguif deguif merged commit f384f62 into ruflin:master Mar 17, 2021
@deguif deguif deleted the replace-call_user_func-by-direct-call branch March 17, 2021 18:58
@deguif deguif added this to the 7.1.1 milestone Mar 24, 2021
@kissifrot
Copy link

Out of curiosity, does it improve performance too?

@deguif
Copy link
Collaborator Author

deguif commented Mar 24, 2021

Out of curiosity, does it improve performance too?

It should, but very very little as it avoids an extra function call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
7.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@deguif @kissifrot @ruflin