added distance precision to GeohashGrid.php #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krewetka Could you also rebase this PR now that CI changes are in? |
deguif
reviewed
Dec 3, 2020
krewetka
force-pushed
the
precision-in-km
branch
2 times, most recently
from
bd59693 to
bc1b4af
Compare
krewetka
force-pushed
the
precision-in-km
branch
from
bc1b4af to
45cc5f9
Compare
just so you know CI is failing sometimes for some strange reason. I had a fail, changed just single test name a bit , restarted it and next time it was ok
|
deguif
reviewed
Dec 4, 2020
deguif
reviewed
Dec 4, 2020
|
Thanks @krewetka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geohashgrid-aggregation.html#_options_3 there is possibility to pass precision as string.
It was also working in earlier versions of Elastica.
Got broken after adding
intto parameter insetPrecision.I think it is better to add second method for that.