Use github action for coding style checks #1878
Conversation
|
Nice! This looks great. I would suggest we add a changelog entry even if though this is not related to the actual code. Still it is a big change to how the project does CI. WDYT about for now keep the travis part in an only remove it when we see it sucessfully working on 2-3 PR's? |
| php-cs-fixer --version | ||
|
|
||
| - name: 'Check PHP code' | ||
| run: 'php-cs-fixer fix --diff --dry-run --allow-risky=yes --using-cache=false' |
There was a problem hiding this comment.
Is it possible to use make run-phpcs instead here? Like this we have only 1 place where we specify the exact params to be run like we have for travis. So local and CI are always in sync.
There was a problem hiding this comment.
I would be in favor to let the setup-php github action setup this, that's used on many PHP projects on github.
Advantage: No probem with extra downloads done by the makefile to install the tools (shipped directly in the GA)
Downside is that we will have to maintain two versions as you stated, the local environment (via makefile) for contributors and the CI one, but I think we can live with it. The CI one will be the source of trust as it would make the pull request / merge checks fail.
Would that be a blocker for you?
Regarding keeping the travis part, I can let the old part but I'm familiar with this setup as I already configured this way on many projects and it works really well. See for example:
deguif
force-pushed
the
run-cs-on-github-action
branch
from
e498039 to
df4d7f8
Compare
|
@deguif Not a blocker at all. I just merged it. I'm much more keen to get CI running again then anything else! Thanks for taking this on. |
See result here: https://github.com/deguif/Elastica/runs/1462981807
Should be accessible here once merged.