Fix Composite::addAfter(null) aggregation behavior #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainneutron
force-pushed
the
add-after-null
branch
from
c137b2c
to
fd83633
Compare
deguif
reviewed
Nov 24, 2020
| @@ -25,6 +25,10 @@ public function addSource(AbstractAggregation $aggregation): self | |||
| */ | |||
| public function addAfter(?array $checkpoint): self | |||
There was a problem hiding this comment.
Cannot we deprecate passing null? So that we can change the type-hint in 8.0 to only allow array and remove the check for null?
There was a problem hiding this comment.
I'd be in favor of keeping it, It's very handy for writing code:
do {
$result = $this->doYourAggregation($after ?? null);
// ...
$after = $result->getAggregations()['composite']['after_key'];
} while (true);
1f1f58c
to
0b60c79
Compare
romainneutron
force-pushed
the
add-after-null
branch
from
0b60c79
to
fa9c890
Compare
|
PR rebased |
ruflin
approved these changes
Dec 10, 2020
deguif
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastica\Aggregation\Composite::addAfteracceptsnullvalue. However, it's not allowed by elasticsearch It returns an error:[composite] after doesn't support values of type: VALUE_NULLThis PR fixes this bug