Use microsecond precision instead of second for connection timeout and connect-timeout #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainneutron
force-pushed
the
ms-precision
branch
from
885d37d
to
26e59ac
Compare
deguif
reviewed
Nov 13, 2020
deguif
reviewed
Nov 13, 2020
romainneutron
force-pushed
the
ms-precision
branch
from
26e59ac
to
48405b5
Compare
|
I've updated the PR according to comments |
…d connect-timeout
romainneutron
force-pushed
the
ms-precision
branch
from
48405b5
to
51e2623
Compare
deguif
approved these changes
Nov 13, 2020
|
Thanks @romainneutron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation only allows second precision for connection timeout and connect-timeout.
This PR provides millisecond precision by accepting float values, and using them if libcurl is compatible with this.