Use Guzzle RequestOptions constants for configuring requests #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
use-guzzle-request-options
branch
from
3b45f4d to
af8799b
Compare
deguif
commented
Oct 20, 2020
deguif
force-pushed
the
use-guzzle-request-options
branch
from
af8799b to
52e1646
Compare
ruflin
approved these changes
Oct 22, 2020
deguif
force-pushed
the
use-guzzle-request-options
branch
from
52e1646 to
9d4955c
Compare
|
Just rebased ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use RequestOptions constants.
The main advantage I see is that it will be easier to spot removed options ;)