Fix sampler aggregation DSL #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
commented
Oct 20, 2020
| */ | ||
| public function sampler($name): Sampler | ||
| public function sampler(string $name): Sampler |
There was a problem hiding this comment.
BC break as type-hint is changed, but this is currently breaking when calling the constructor with another type-hint as constructor only accepts a string for name argument.
|
Could you add a changelog entry? We could consider this a bugfix :-) |
deguif
force-pushed
the
fix-sampler-aggregation-dsl
branch
from
be6be94
to
4181ab9
Compare
|
@ruflin changelog added, can be merged ;) |
|
Merging as I added the changelog entry ;) |
|
Thanks! |
|
BTW glad to see you used squash merge to keep the history clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.