Add PercentilesBucket aggregation #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
reviewed
Oct 7, 2020
Co-authored-by: François-Xavier de Guillebon <deguif@gmail.com>
|
Thanks for your suggestions @deguif! I've updated the code. I can see that one of the jobs failed on Travis, but it seems that it's not related to changes in the code, but rather to some problem in the test-runner (all other jobs run successfully) |
|
@mkosiedowski Thanks for the contribution. I restarted the failing test. But was not sure if it might be related to a recent change in master and you might have to rebase on master? Lets see if it goes green or not. If not, could you rebase on master and push again? |
|
Thanks @ruflin! It seems that it's all green now :) |
|
Merged! Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for PercentilesBucket - #1805