Allow string argument in AbstractUpdateAction::setRefresh #1791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1475
Currently,
AbstractUpdateAction::setRefresh
only accepts boolean values:true
- to perform an immediate refreshfalse
- to not refresh at allThe documentation, however, strongly suggests the usage of
wait_for
option to ensure a good cluster performance while doing the refresh operation. But the problem is thatwait_for
is of typestring
; thus, we cannot pass it as an argument to the method.This modifies
AbstractUpdateAction::setRefresh
so that arguments of typestring
such aswait_for
can also be passed to the method. Additionally, the return type of its getter counterpart,AbstractUpdateAction::getRefresh
, has also been modified to mirror the accepted types of the setter.