Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string argument in AbstractUpdateAction::setRefresh #1791

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Allow string argument in AbstractUpdateAction::setRefresh #1791

merged 2 commits into from
Aug 10, 2020

Conversation

knsarsaba
Copy link
Contributor

@knsarsaba knsarsaba commented Aug 6, 2020

Ref #1475

Currently, AbstractUpdateAction::setRefresh only accepts boolean values:

  • true - to perform an immediate refresh
  • false - to not refresh at all

The documentation, however, strongly suggests the usage of wait_for option to ensure a good cluster performance while doing the refresh operation. But the problem is that wait_for is of type string; thus, we cannot pass it as an argument to the method.

This modifies AbstractUpdateAction::setRefresh so that arguments of type string such as wait_for can also be passed to the method. Additionally, the return type of its getter counterpart, AbstractUpdateAction::getRefresh, has also been modified to mirror the accepted types of the setter.

@ruflin ruflin merged commit 9146c80 into ruflin:master Aug 10, 2020
@ruflin
Copy link
Owner

ruflin commented Aug 10, 2020

@knsarsaba Thanks for this contribution. It is so nice to be able to just merge such perfect contributions!

@knsarsaba knsarsaba deleted the refresh-wait-for branch August 10, 2020 17:08
@thePanz thePanz mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants