Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in usage of ltrim #1783

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

viable-hartman
Copy link
Contributor

Pretty sure the intention of this was to remove the '/', not lose the path, which this would do. So fixing it. Looks like this has been in the code going back quite a while, so might want to port it back.

@ruflin
Copy link
Owner

ruflin commented May 25, 2020

This indeed looks odd :-( I wonder why this didn't break other things.

@viable-hartman

  • Could you add a changelog entry?
  • Do you see a way we could test this change?

@viable-hartman
Copy link
Contributor Author

@ruflin I will add a changelog entry once I get a tiny bit of spare time. I did not trace through the code to see what or if this actually breaks anything, but believe it's probably rarely run into because the default path usually is just '/' which of course wouldn't affect much. Further it looks like other areas of the code do ltrim like this to deal with path, so perhaps those were there because this has been broken. So short answer is, I'd have to trace the code to determine where to test, but just noticed this was wrong due to another piece of older code I was looking at.

@ruflin
Copy link
Owner

ruflin commented Jun 3, 2020

@viable-hartman Thank you! Hoping you get some spare time soon ;-)

@deguif
Copy link
Collaborator

deguif commented Mar 23, 2021

@viable-hartman would you be able to add a changelog?

@deguif deguif added this to the 7.1.1 milestone Mar 24, 2021
@deguif
Copy link
Collaborator

deguif commented Mar 24, 2021

@ruflin I just added a changelog here.
If you could have a look as I planned it for 7.1.1 too ;)

@deguif deguif merged commit 5ca8cfc into ruflin:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants