Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the HTTP content type as specified, whatever the content of the body #1780

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

romainneutron
Copy link
Contributor

This solve the issue I reported here at #1779

@ruflin
Copy link
Owner

ruflin commented May 19, 2020

I would like to better understand why this is needed as I would think we should not have a different content type then the body.

@ruflin
Copy link
Owner

ruflin commented Jun 10, 2020

Somehow I misread the code initial but now I see you only moved where the content-type is served. Any chance you could add a changelog entry and potentially a test for this? An integration test with your example you had in #1779 would be really nice.

@deguif
Copy link
Collaborator

deguif commented Mar 23, 2021

@romainneutron would you be able to rebase and add a changelog?

@deguif
Copy link
Collaborator

deguif commented Mar 24, 2021

@ruflin should be the last one planned for 7.1.1

@deguif deguif merged commit c356bac into ruflin:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 6.x - Http Transport: Use forceMerge() fails because of HTTP request missing its content type
3 participants